Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
JIRA#DescriptionJustificationFiles AffectedKFS / RICE

Comments

KPS-231Added two new fields to BO and Datadictionary.This class is not persisted and has a custom lookup; could not apply the extended attributes easily. And extending the class was tried but cause a lot of code replication and resulting potential bugs.

AccountStatusCurrentFunds.java

AccountStatusCurrentFunds.xml

KFS 
KPS-135Line 160 was changed to fix what appears to be a bug with base code.Extending this class broke hierarchy with other types of PO and PURAP documents.PurchaseOrderAmendmentDocumentKFS 
KPS-162Added code to fix incorrect caching, and only generate account summary when needed.The three classes modified are in the middle of the class hierarchy, and extending them for customization would cause a complicated chain of refactoring throughout the hierarchy.

PurchasingAccountsPayableDocumentBase

PurchasingAccountsPayableActionBase

PurchasingAccountsPayableFormBase

KFS 
KPS-5Made private members of org class protected.When extending the service class, there was a need to access the private members of the parent class, thus the scope of the properties were changed to protected.CashManagementServiceImpl

KFS